Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastcache fix update for v.1.12.1 #267

Merged
merged 8 commits into from
Nov 1, 2023

Conversation

magicxyyz
Copy link
Contributor

This PR resolves conflict caused by #264

  • setting fastcache finalizer is moved to fastcache fork: call Cache.Reset() in finalizer fastcache#1
  • instead of exposing fastcache.Cache.Reset() via new ResetCleans method, trie.backend.Close() implementations are updated in hashdb.Database.Close and pathdb.Database.Close to reset corresponding caches

@cla-bot cla-bot bot added the s CLA signed label Nov 1, 2023
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tristan-Wilson Tristan-Wilson merged commit 4b27832 into merge-v1.12.1 Nov 1, 2023
3 checks passed
@Tristan-Wilson Tristan-Wilson deleted the merge-v.1.12.1-fastcache-fix-update branch November 1, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants